Svelte: Use JSDocs in JS CLI templates and put manual enum arg type back as it is not inferred #20042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpeulen
added
svelte
bug
ci:daily
JReinhold
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
We should probably support typing with JSDocs (and testing it in CI) as that is a fairly common thing in the Svelte community. But that's outside the scope of this PR.
Unless we already support it, then I think we should add JSDocs to props instead of defining argTypes manually.
kasperpeulen
force-pushed
the
kasper/manual-arg-types-svelte-js
branch
from
83910db
to
0f891f9
Compare
kasperpeulen
force-pushed
the
kasper/manual-arg-types-svelte-js
branch
from
0f891f9
to
3d3265e
Compare
kasperpeulen
changed the title
JSDocs actually work! (except for enums/string literal unions) So I use that and only specify the argType for the enum. Thanks! 🚀 |
kasperpeulen
removed
the
ci:daily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did