Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controls: Fix color control not resetting when initial value is defined #20049

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Controls: Fix color control not resetting when initial value is defined #20049

merged 4 commits into from
Dec 9, 2022

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Dec 1, 2022 •
edited by JReinhold
Loading

#17171

What I did

Update useEffect hook in Color.tsx file to set the value of color input to initial value

How to test

@gitstart gitstart marked this pull request as ready for review December 2, 2022 03:44
JReinhold
JReinhold requested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a very detailed PR, love the Loom.

Could you try out my suggestion - or something similar - and see if that works?

code/ui/blocks/src/controls/Color.tsx Show resolved Hide resolved
@JReinhold JReinhold changed the title UI: Fix color control not resetting UI: Fix color control not resetting when initial value is defined Dec 7, 2022
@JReinhold JReinhold changed the title UI: Fix color control not resetting when initial value is defined Controls: Fix color control not resetting when initial value is defined Dec 7, 2022
JReinhold
JReinhold approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@JReinhold JReinhold merged commit 5642c93 into storybookjs:next Dec 9, 2022
@shilman shilman mentioned this pull request Dec 9, 2022
Closed
@gitstart
Copy link
Contributor Author

gitstart commented Dec 9, 2022

PR pushed through Gitstart with contributions from @BikashSah999 @phunguyenmurcul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees

@JReinhold JReinhold

Labels
addon: controls bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gitstart @JReinhold @yannbf