Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: revamp interactions e2e test #20060

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Build: revamp interactions e2e test #20060

merged 1 commit into from
Dec 2, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 2, 2022

Issue: N/A

What I did

Our CI was flaky, due to the locator count not working as intended. This PR fixes that

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged. labels Dec 2, 2022
@yannbf yannbf changed the title fix flakliness on interactions e2e test Build: revamp interactions e2e test Dec 2, 2022
kasperpeulen
kasperpeulen approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks!

@yannbf yannbf merged commit 276add3 into next Dec 2, 2022
@yannbf yannbf deleted the fix/flaky-e2e-tests branch December 2, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannbf @kasperpeulen