Add --tag option to upgrade script
#20075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
reviewed
Dec 3, 2022
There was a problem hiding this comment.
@tmeasday We probably should update the docs as well, maybe in a separate PR? cc @jonniebigodes
|
@tmeasday regarding not using latest version of the CLI, I belive the problem is fixed if people always make sure to use I just tested this out and it's :chefskiss: No more weird canary versions!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Allow passing
--tagto the prerelease script to use a npm dist-tag.How to test
node path/to/cli upgrade --tag next-- check it worksnode path/to/cli upgrade --prerelease --tag next-- check it errorsI'm not sure what we should do about not using the right version of the CLI to upgrade to later version of the packages. Did you have thoughts there @yannbf?