SvelteKit: Automigration #20094
Merged
SvelteKit: Automigration #20094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eltekit-framework-automigration
…eltekit-framework-automigration
…storybookjs/storybook into jeppe/sveltekit-framework-automigration
…eltekit-framework-automigration
shilman
requested changes
Dec 9, 2022
|
Looking great! My primary concern from above is the |
Co-authored-by: Michael Shilman <[email protected]>
…storybookjs/storybook into jeppe/sveltekit-framework-automigration
JReinhold
commented
Dec 9, 2022
| const index = properties.findIndex( | ||
| (p) => | ||
| (t.isIdentifier(p.key) && p.key.name === prop) || | ||
| (t.isStringLiteral(p.key) && p.key.value === prop) |
There was a problem hiding this comment.
@shilman we missed the fact that keys could be string literals ( { 'core': {...} } as opposed to { core: {...} }) which they were. Luckily my AST-fu has 10x today so I figured it out.
I'm sure there are other edge cases, but I think this is good for now.
shilman
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates an automigration that handles migrating SvelteKit projects from an existing Svelte+Vite setup to the new SvelteKit Storybook framework.
It both migrates 6.x and 7.0 setups:
@storybook/svelte-vite@storybook/svelte+ builder:@storybook/builder-vite@storybook/svelte+ builder:storybook-builder-viteTwo other related changes:
svelteOptionsin most Vite-based projects.@storybook/svelteas a dependency to@storybook/sveltekitwhich is needed for some reason, even though it's transitive through@storybook/svelte-vite