Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Run sb init locally in sandbox creation #20100

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Build: Run sb init locally in sandbox creation #20100

merged 3 commits into from
Dec 6, 2022

Conversation

kasperpeulen
Copy link
Contributor

What I did

  • Switched from getting the after sandboxes, to the before sandboxes and running on top of that sb init
  • This makes sure that changes in CLI templates are reflected immediately in CI
  • Also this gives a nice way to E2E tests our sb init command

@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label Dec 6, 2022
@ndelangen ndelangen mentioned this pull request Dec 6, 2022
Closed
@ndelangen
Copy link
Member

ndelangen commented Dec 6, 2022 •
edited
Loading

@kasperpeulen @shilman is going to revert a PR to fix this.

If this goes green, we merge it: #20105
Then merge next into your branch.

That should .. should .. make this green, and then can be merged!

@ndelangen ndelangen merged commit c294a1c into next Dec 6, 2022
@ndelangen ndelangen deleted the kasper/sb-1048-run-sb-init-locally-on-repro-templates branch December 6, 2022 12:40
@kasperpeulen
Copy link
Contributor Author

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@kasperpeulen kasperpeulen

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperpeulen @ndelangen