Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Restore deprecated blocks entry point #20246

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Addon-docs: Restore deprecated blocks entry point #20246

merged 1 commit into from
Dec 14, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 14, 2022 •
edited
Loading

Issue: #20149

What I did

Until we have an automigration, add back blocks entry point

Self-merging @tmeasday

How to test

  • Run a sandbox
  • Change the import in an MDX file to addon-docs/blocks
  • Verify that it doesn't break and there's a deprecation warning in the browser console

@shilman shilman added maintenance User-facing maintenance tasks addon: docs labels Dec 14, 2022
tmeasday
tmeasday approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 970ebea into next Dec 14, 2022
@shilman shilman deleted the shilman/20149-restore-docs-blocks-entry branch December 14, 2022 10:17
@shilman shilman mentioned this pull request Dec 14, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
addon: docs maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday