Vite/Svelte: Remove addon-svelte-csf dep

[JReinhold]

Upgrade peer dependency @storybook/addon-svelte-csf to ^3.0.0-next.0.

Same PR on the other end: storybookjs/addon-svelte-csf#81. Together they (hopefully) fix storybookjs/addon-svelte-csf#82

Also fixes storybookjs/addon-svelte-csf#83

[IanVS]

Now that the svelte addon supports vite, we should remove the duplicated logic in svelte-vite/src/plugins/csf-plugin.ts

[JReinhold]

Now that the svelte addon supports vite, we should remove the duplicated logic in svelte-vite/src/plugins/csf-plugin.ts

Agree. Let's do that in a separate PR, so we can get this peerDeps mismatch out the door.

[IanVS]

Will there be any complications from running the same logic twice, I wonder though.

[JReinhold]

Will there be any complications from running the same logic twice, I wonder though.

This is probably what's causing storybookjs/addon-svelte-csf#83 actually.

[shilman]

Why is this both a dependency and a peer dependency? I think it shouldn't be a dependency @JReinhold @IanVS

[IanVS]

In fact it should be removed entirely, from both peer and dependencies. We included it previously in peer dependencies because we were using it in the csf-plugin. But now we don't need to with the latest version of the addon.

@JReinhold there are also some type definition files that can be removed now too, along with plugins/csf-plugin.ts

[shilman]

Otherwise LGTM

[shilman]

Suggested change

"@storybook/addon-svelte-csf": "^3.0.0-next.0",

[IanVS]

I've pulled in next and removed @storybook/addon-svelte-csf entirely, now that it handles the vite config on its own.

[shilman]

Thanks for handling this @IanVS ! Looks great!! 💯

[JReinhold]

Thanks for finishing this up @IanVS ! I was way too hasty in this PR.

I also initially thought about removing addon-csf entirely from does, but I convinced myself that it should stay as peer deps and optional, because that would allow us to specify which version was required, so users didn't end up installing the old version.
But maybe that doesn't make any sense.

[IanVS]

We don't use peer deps for any other community addons, so I didn't think it made sense for this one either. It's up to the user to install the correct version of whatever plugin they're using for their version of Storybook. If anything, we could update some documentation to make it clear what has to be installed. That's just my humble opinion, though. Happy to be overruled if others disagree.