Fix: addon-storysource has no managerEntry, but defines a register and preset #20304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
valentinpalkovic
approved these changes
Dec 16, 2022
|
It does highlight the importance of managerEntries not exporting anything. If they do the whole thing explodes. That might be a reason to look for an alternative solution, or a method via which we ensure to strip out exports via esbuild plugin or setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running on Ian's branch, and ran into a problem where the managerEntry exported something, therefore breaking the
try,catchwrapping.So I investigated a bit, and noticed this weird
registerthing, AND the managerEntry also being defined inpreset. Changing it seemed to help.