Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: add "missing-babelrc" automigration #20341

Merged
merged 6 commits into from
Jan 13, 2023
Merged

CLI: add "missing-babelrc" automigration #20341

merged 6 commits into from
Jan 13, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 20, 2022 •
edited by shilman
Loading

Issue: #20302 #20423

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@IanVS IanVS mentioned this pull request Dec 30, 2022
Closed
@yannbf yannbf force-pushed the feat/babelrc-automigration branch 2 times, most recently from e7a35ad to 600a5ec Compare January 5, 2023 15:17
@ivangabriele
Copy link

ivangabriele commented Jan 6, 2023 •
edited
Loading

Thanks @yannbf for this PR. I'm also suggesting we change the copy for this doc page:

https://github.com/storybookjs/storybook/blob/next/docs/configure/typescript.md

Storybook has built-in TypeScript support, so your TypeScript project should work with zero configuration needed.

This doesn't seem to apply to v7 anymore (as maybe some other parts in this page).

@ndelangen ndelangen self-assigned this Jan 9, 2023
@ndelangen
Copy link
Member

Good to merge @yannbf ?

@yannbf yannbf merged commit cd99f77 into next Jan 13, 2023
@yannbf yannbf deleted the feat/babelrc-automigration branch January 13, 2023 16:43
@shilman shilman mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen left review comments

@IanVS IanVS IanVS left review comments

@JReinhold JReinhold JReinhold requested changes

Assignees

@yannbf yannbf

@ndelangen ndelangen

Labels
cli feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yannbf @ivangabriele @ndelangen @IanVS @JReinhold