Set min-height relative to the viewport and the zoom level. #20352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
approved these changes
Dec 29, 2022
|
@neogeek Thank you for your contribution. I have tested your changes. The fix works as expected! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Set the
min-heightaccording to thezoomlevel. Previously themin-heightwas set based on the viewport height (100vh), but with this fix, the height is now relative to the viewport as well as the zoom level. This prevents overflow when the layout is centered. It also works in the default layout.How to test
Zoom in without this patch, the preview layout set to centered and the controls open. The layout will overflow. With this patch, the layout will remain in the center when zooming.
Screenshots
Before
After