Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: Update autodocs migration to deal with docs.docsPage #20379

Merged
merged 3 commits into from
Jan 2, 2023

Conversation

tmeasday
Copy link
Member

Issue: #20364 (comment)

What I did

Updated the docs.autodocs migration to convert/copy over the old value and warn if you need to change tags.

How to test

Run migration against some converted and unconverted projects.

@tmeasday tmeasday added maintenance User-facing maintenance tasks addon: docs labels Dec 22, 2022
@tmeasday tmeasday requested a review from yannbf December 22, 2022 11:12
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but looks like there are some TS issues @tmeasday

code/lib/cli/src/automigrate/fixes/autodocs-true.ts Outdated Show resolved Hide resolved
code/lib/cli/src/automigrate/fixes/autodocs-true.ts Outdated Show resolved Hide resolved
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmeasday can you fix the TS error here?

@tmeasday tmeasday merged commit 9bf37c3 into next Jan 2, 2023
@tmeasday tmeasday deleted the update-autodocs-automigration branch January 2, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants