Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte: Do not warn about .svelte files in storyStoreV7 #20442

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Svelte: Do not warn about .svelte files in storyStoreV7 #20442

merged 1 commit into from
Dec 30, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Dec 30, 2022

Issue:

We are throwing warnings like:

Cannot process .svelte file with storyStoreV7: src/lib/Button/Button.stories.svelte

But this isn't true, we do support them now.

What I did

Added .svelte to the list of extensions that can be processed in storyStoreV7.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@IanVS IanVS mentioned this pull request Dec 30, 2022
Closed
@valentinpalkovic valentinpalkovic merged commit 2115c7a into next Dec 30, 2022
@valentinpalkovic valentinpalkovic deleted the svelte-storystorev7-warning branch December 30, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

Assignees
No one assigned
Labels
bug builder-vite svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanVS @valentinpalkovic