CLI: overhaul storybook repro command and rename it to storybook sandbox
#20507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
force-pushed
the
chore/make-repro-next-default-command
branch
from
567e3da
to
02f9492
Compare
ndelangen
reviewed
Jan 10, 2023
yannbf
force-pushed
the
chore/make-repro-next-default-command
branch
from
02f9492
to
2737195
Compare
ndelangen
reviewed
Jan 10, 2023
yannbf
force-pushed
the
chore/make-repro-next-default-command
branch
from
0894072
to
f7b089b
Compare
|
The failures of this PR are related to a recent regression from |
- sb repro as it was is entirely removed - sb repro-next becomes sb repro
- replace screenshots with new sb repro command screenshots
yannbf
force-pushed
the
chore/make-repro-next-default-command
branch
from
f7b089b
to
46bbd21
Compare
yannbf
changed the title
storybook repro command and rename it to storybook sandbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
The
sb reproas we know it was entirely removed, as it's been "deprecated" for some time.The former
sb repro-nextcommand becomessb sandbox(and is aliased asreprofor compatibility purposes), with the updated functionality bringing the correct sandboxes.TODO:
repro-templates-temprepository tosandboxesHow to test
If your answer is yes to any of these, please make sure to include it in your PR.