fix typing on useArgs #20610
Merged
fix typing on useArgs #20610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #18122 by @annacc-everlaw
Issue:
useArgsis typed incorrectly.What I did
Fixed
useArgsto take a type parameter,P, which should be the type of the args for your story. By default, it's set toArgsso that it's backwards compatible. Additionally, fixed theresetArgsfunction to be a(string[]) => voidrather than a([string]) => void, as a[string]makes no sense in this context (and is incorrect).How to test
This is just a type change, so this can be tested by ensuring that things are typed correctly in your story when using
useArgs<YourStoryArgType>.