Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Implement Controls block #20683

Merged
merged 7 commits into from
Jan 20, 2023
Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jan 19, 2023

Telescoping on #20664

Issue: N/A

What I did

How to test

  • See stories
  • Run an Autodocs page in a sandbox.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code/ui/blocks/src/argsHelpers.ts is an empty file?

Looks very clean!

code/ui/blocks/src/blocks/Controls.tsx Outdated Show resolved Hide resolved
code/ui/blocks/src/blocks/Controls.tsx Show resolved Hide resolved
code/ui/blocks/src/blocks/Controls.tsx Outdated Show resolved Hide resolved
code/ui/blocks/src/examples/ControlsParameters.stories.tsx Outdated Show resolved Hide resolved
code/ui/blocks/src/examples/ControlsParameters.stories.tsx Outdated Show resolved Hide resolved
Copy link
Member Author

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply @JReinhold's suggestions

code/ui/blocks/src/blocks/Controls.tsx Show resolved Hide resolved
@Alishfie
Copy link

Telescoping on #20664

Issue: N/A

What I did

How to test

  • See stories
  • Run an Autodocs page in a sandbox.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Base automatically changed from tom/sb-1149-implement-argtypes-block to next January 20, 2023 00:01
@tmeasday tmeasday merged commit 7eaa9c4 into next Jan 20, 2023
@tmeasday tmeasday deleted the tom/sb-1152-implement-controls-block branch January 20, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants