Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow Flow syntax in stories #21859

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Conversation

FezVrasta
Copy link
Contributor

Closes #21816

What I did

Improved the csf tools to use the typescript or flow parser depending by the file it's parsing.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic
Copy link
Contributor

Hi @FezVrasta,

Thank you so much for your contribution!

It seems, that there are some Typescript related errors on your branch: https://github.com/storybookjs/storybook/actions/runs/4718179558/jobs/8367500690?pr=21859#step:4:437

@FezVrasta
Copy link
Contributor Author

FezVrasta commented Apr 20, 2023

I'll send a fix in a minute

CleanShot 2023-04-20 at 4 10 01@2x

@FezVrasta
Copy link
Contributor Author

I'm sorry I can't get eslint to work locally, it complains about the storybook preset missing even though it's installed. If someone else could fix the formatting errors and get this merged I'd be grateful.

@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 25, 2023
@valentinpalkovic valentinpalkovic merged commit 7bd6976 into storybookjs:next Apr 25, 2023
@FezVrasta FezVrasta deleted the patch-1 branch April 25, 2023 12:21
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 3, 2023
shilman pushed a commit that referenced this pull request May 3, 2023
fix: allow Flow syntax in stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csf feature request patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook 7 + Vite + Flow not working
4 participants