Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Use vite@beta on sandboxes #22030

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Build: Use vite@beta on sandboxes #22030

merged 6 commits into from
Apr 12, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 11, 2023

Closes #

What I did

Fixed the command that generates a beta vite project for the sandboxes

How to test

Generate and push sandboxes (next) should be green for this PR

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added the build Internal-facing build tooling & test updates label Apr 11, 2023
@yannbf yannbf added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 11, 2023
@github-actions
Copy link
Contributor


Fails
🚫 A 'patch' label is required to merge during stabilization.

Patch PRs are small bug fixes, build updates, and documentation changes.
They do not include new features or more disruptive bugfixes.

These changes will be first released on 7.1-alpha, then patched back to 'main'
after they have been verified to be correct and released as 7.0.x patch releases.

After the stabilization period ends (ETA 2023-04-12), the 'patch' label
will no longer be required to merge into next, and we will merge ALL accepted
PRs to 'next' and release them on 7.1-alpha. Patch PRs will be
patched back to 'main' and released in 7.0.x patch releases.

Generated by 🚫 dangerJS against 44cabd7

@shilman shilman merged commit 6901b5d into next Apr 12, 2023
@shilman shilman deleted the fix/vite-sandboxes branch April 12, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants