Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: simplify the export type of addon actions decorator so it doesn't get generated incorrectly #22175

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

ndelangen
Copy link
Member

Closes #21820

What I did

Looks like tsup is generating the typings wrong for this file, referencing a path that only exists in the monorepo.

I traced the output code, it's trying to reference, and it's just a function type of any to any, pretty useless.

So trying to fix the actual issue inside tsup can wait; I fixed the issue by making the type better by referencing @storybook/types instead.
I verified the output typings file is correct that way.

@ndelangen ndelangen self-assigned this Apr 20, 2023
@ndelangen ndelangen added bug addon: actions patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 20, 2023
@ndelangen
Copy link
Member Author

👋 @jattasNI @shannonmoeller @stof care to review? 🙏

@ndelangen ndelangen merged commit 6d9757f into next Apr 20, 2023
@ndelangen ndelangen deleted the norbert/fix-21820 branch April 20, 2023 11:02
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 24, 2023
shilman pushed a commit that referenced this pull request Apr 24, 2023
Bug: simplify the export type of addon actions decorator so it doesn't get generated incorrectly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: actions bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 7.0.0-rc.8 Cannot find module 'lib/types/dist' in @storybook/html
3 participants