Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF: Improve error message for bad default export #22190

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 21, 2023

Closes #21703

What I did

Added more specific error checking when there is an invalid default export in CSF

Self-merging @tmeasday

How to test

See attached unit test

@shilman shilman added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch csf labels Apr 21, 2023
@shilman shilman merged commit 13a63bd into next Apr 21, 2023
@shilman shilman deleted the shilman/21703-csf-improve-error branch April 21, 2023 03:35
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 24, 2023
shilman added a commit that referenced this pull request Apr 24, 2023
…error

CSF: Improve error message for bad default export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csf maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to abstract the CSF Default Export with a function
1 participant