Fix vue-cli/default-js sandbox #22259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
reviewed
Apr 26, 2023
Some vue sandboxes do not support typescript. Hence, Stories and vue files shouldn't have Typescript types. You can place stories into code/renderes/vue3/template/stories_vue3-vite-default-ts to provide stories only for the vue3-vite/default-ts sandbox
…Vue, and modify the linkPackageStories function to handle the 'stories' directory
valentinpalkovic
force-pushed
the
valentin/fix-vue-cli-default-js-sandbox
branch
from
4525e92
to
a3d6c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Some vue sandboxes do not support typescript. Hence, Stories and vue files shouldn't have Typescript types. You can place stories into code/renderes/vue3/template/stories_vue3-vite-default-ts to provide stories only for the vue3-vite/default-ts sandbox
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]