Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate @storybook/addon-viewbook to strict ts #22339

Merged
merged 2 commits into from
May 3, 2023
Merged

Migrate @storybook/addon-viewbook to strict ts #22339

merged 2 commits into from
May 3, 2023

Conversation

1234tgk
Copy link
Contributor

@1234tgk 1234tgk commented May 2, 2023 •
edited
Loading

Issue #22176 (partially)

What I did

Adjust the code so that the package allows strict typing.

How to test

Run yarn check on @storybook/addon-viewbook directory.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@1234tgk 1234tgk force-pushed the ts-migrate/addon-viewport branch 2 times, most recently from 51b867d to ed2c728 Compare May 2, 2023 00:41
@1234tgk 1234tgk mentioned this pull request May 2, 2023
Closed
@1234tgk 1234tgk force-pushed the ts-migrate/addon-viewport branch from ed2c728 to 9f01d14 Compare May 2, 2023 16:50
@1234tgk 1234tgk changed the title convert @storybook/addon-viewbook to strict ts Migrate @storybook/addon-viewbook to strict ts May 3, 2023
@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label May 3, 2023
@kasperpeulen kasperpeulen self-requested a review May 3, 2023 10:07
@kasperpeulen kasperpeulen self-assigned this May 3, 2023
kasperpeulen
kasperpeulen requested changes May 3, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some feedback :)

code/addons/viewport/src/Tool.tsx Show resolved Hide resolved
code/addons/viewport/src/Tool.tsx Outdated Show resolved Hide resolved
code/addons/viewport/src/Tool.tsx Outdated Show resolved Hide resolved
@1234tgk 1234tgk force-pushed the ts-migrate/addon-viewport branch from 0313e52 to fe02579 Compare May 3, 2023 13:15
@1234tgk
Copy link
Contributor Author

1234tgk commented May 3, 2023

@kasperpeulen Thank you for the feedback. I made some adjustments per your request. Let me know if there's more to change 👍

@1234tgk 1234tgk requested a review from kasperpeulen May 3, 2023 13:26
kasperpeulen
kasperpeulen approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperpeulen kasperpeulen merged commit bc93263 into storybookjs:next May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees

@kasperpeulen kasperpeulen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1234tgk @kasperpeulen @taehyeon-envoi