Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server: Add json indexer #22460

Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented May 8, 2023

Closes #20627

Telescopes off #22443

What I did

Heavily inspired by #22296

  • Fixed the sample stories to include the server URL
  • Added a json indexer to @storybook/server
  • Added a server sandbox for testing

@yannbf I'll improve the CLI behavior in a follow-up PR

How to test

yarn task --task dev --template internal/server-webpack5

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch server labels May 8, 2023
@shilman shilman requested a review from yannbf May 8, 2023 16:34
const meta: StaticMeta = {
title: json.title,
};
const stories: IndexedStory[] = json.stories.map((story: any) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to type story here?

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shilman and others added 4 commits May 9, 2023 10:55
@shilman shilman merged commit b068457 into shilman/fix-cli-server-init May 9, 2023
@shilman shilman deleted the shilman/20627-fix-server-indexer branch May 9, 2023 07:12
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants