Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix sandbox generation scripts #22620

Merged
merged 6 commits into from
May 18, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented May 18, 2023

Looks like we have the sandbox generation github action failing.

@ndelangen ndelangen self-assigned this May 18, 2023
@ndelangen ndelangen added patch:yes Bugfix & documentation PR that need to be picked to main branch build Internal-facing build tooling & test updates labels May 18, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the same for other sandbox scripts that have a similar logic 🙏

@ndelangen ndelangen requested a review from yannbf May 18, 2023 10:24
@@ -360,7 +360,7 @@ const baseTemplates = {
'vue-cli/vue2-default-js': {
name: 'Vue-CLI (Vue2 JS)',
script:
'npx -p @vue/cli vue create . --default --packageManager=yarn --force --merge --preset="Default (Vue 2)" && echo "module.exports = {}" > webpack.config.js',
'npx -p @vue/cli vue create . --default --packageManager=yarn --force --merge --preset="Default (Vue 2)" && cd {{beforeDir}} && echo "module.exports = {}" > webpack.config.js',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these vite commands were not using {{beforeDir}} but rather . so it worked without this change. I think it's better to use {{beforeDir}} so can you change the . to {{beforeDir}} and test it if all works well?

@yannbf yannbf changed the title fix sandbox generation script for preact Build: Fix sandbox generation scripts May 18, 2023
@yannbf yannbf merged commit 49a92bd into next May 18, 2023
@yannbf yannbf deleted the norbert/fix-sandbox-generation-script branch May 18, 2023 16:39
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 22, 2023
shilman pushed a commit that referenced this pull request May 22, 2023
…tion-script

Build: Fix sandbox generation scripts
@shilman shilman mentioned this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants