-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: move builders #22751
Merged
Merged
Build: move builders #22751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
force-pushed
the
norbert/move-builders
branch
from
May 26, 2023 14:39
f408d70
to
1241545
Compare
# Conflicts: # code/yarn.lock
JReinhold
reviewed
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JReinhold
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved 3 packages into their own subdir (a child directory of
code
) for organizational purposes.The 3 packages I moved:
lib/builder-manager
➡️builders/builder-manager
lib/builder-vite
➡️builders/builder-vite
lib/builder-webpack5
➡️builders/builder-webpack5
Having the builders all in the same place will make it easier to focus on builder work, and the builders won't be a bit of a distraction when coding on other
lib/*
packages.Any code-changes in this PR are only to make tools such as eslint, etc, and CI understand where the code moved to.