Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: move deprecated packages #22753

Merged
merged 3 commits into from
May 26, 2023
Merged

Build: move deprecated packages #22753

merged 3 commits into from
May 26, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented May 24, 2023

I've moved 6 packages into their own subdir (a child directory of code) for organizational purposes.

The 6 packages I moved:

lib/client-api ➡️ deprecated/client-api
lib/preview-web ➡️ deprecated/preview-web
lib/addons ➡️ deprecated/addons
lib/core-client ➡️ deprecated/core-client
lib/manager-api-shim ➡️ deprecated/manager-api-shim
lib/store ➡️ deprecated/store

Having the deprecated packages will make it so they are not a distraction when coding on other lib/* packages.

Any code-changes in this PR are only to make tools such as eslint, etc, and CI understand where the code moved to.

@ndelangen ndelangen self-assigned this May 24, 2023
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels May 24, 2023
@ndelangen ndelangen requested a review from JReinhold May 25, 2023 06:54
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

searched for references to lib/X here as well, and only found some in yarn.lock in test-storybooks. I'm not sure what the status with those are.

@ndelangen
Copy link
Member Author

Like I mentioned in the other PR as well... I think those are not maintained at the moment, and don't work.
Why keep them around? I'm not sure.

But updating those lockfiles would be waste of my time, for sure.

Base automatically changed from norbert/move-builders to next May 26, 2023 21:20
@ndelangen ndelangen merged commit 99617fb into next May 26, 2023
@ndelangen ndelangen deleted the norbert/move-shims branch May 26, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants