Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix the local storybook #22805

Merged
merged 5 commits into from
May 26, 2023
Merged

Conversation

ndelangen
Copy link
Member

I found the local dev of storybook was broken

@ndelangen
Copy link
Member Author

@ndelangen
Copy link
Member Author

Final findings:

glob is being resolved to the wrong location in the monorepo workspace, for some reason.
I logged require.resolve('glob/package.json') and the output was wild! it resolved glob v7 from framework/react-vite 🤯

This is just really really wrong, and I don't know how to properly fix it.
I suspect it's something symlink/node related that we do for linked sandboxes.

I made glob be bundled in, that way it can't resolve the wrong thing.

@tmeasday I'd love to hear your ideas on what might be causing the issue and how to properly fix, you're our symlinking expert ;)

For now, I'm going to unblock next by merging this 🎉

@ndelangen ndelangen merged commit 1658ac0 into next May 26, 2023
@ndelangen ndelangen deleted the norbert/fixing-local-dev-storybook branch May 26, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants