-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs live examples #3019
Docs live examples #3019
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3019 +/- ##
=========================================
+ Coverage 37.28% 37.3% +0.01%
=========================================
Files 435 435
Lines 9432 9427 -5
Branches 909 910 +1
=========================================
Hits 3517 3517
+ Misses 5375 5336 -39
- Partials 540 574 +34
Continue to review full report at Codecov.
|
Have troubles to run docs on windows. Will investigate it later. |
README.md
Outdated
### 3.4.alpha | ||
> Note, this is an Alpha version. Some of the features still might not be released | ||
|
||
- [React Official](https://master--storybooks-official.netlify.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just https://storybooks-official.netlify.com
I'm also not sure about the "React Official" naming, would like to hear from @tmeasday and @ndelangen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I feel some kind of conflict between showing the official storybook UI and showing the examples...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I wouldn't call it that. Don't we have a "React" example too? (cra-kitchen-sink
).
official-storybook
is like Storybook's storybook. Not quite sure how best to put that ;) Maybe it doesn't actually need to be on this page?
If nobody rejects the wording, feel free to merge 😉 |
AFAIK, there is almost nothing valuable to user in
I would say, if we want to have a Storybook's storybook, we should put there only the stories of the actual UI. And separate all the other stuff to a different place. I am not sure regarding the naming though. (Official, Storybook's Storybook, StoryStoryBook 😬). |
The reason why it's in the same place is that it's much more convenient for development. |
Issue: Add live examples to docs
What I did