Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4643 fix docgen description displaying for info addon #4685

Merged

Conversation

MihaChicken
Copy link

Issue: #4643

What I did

  1. Fix lookup for docgen description to look for component name(story.kind) instead of story name
  2. Add some tests to cover this usecase

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #4685 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4685      +/-   ##
==========================================
+ Coverage   35.59%   35.75%   +0.16%     
==========================================
  Files         557      557              
  Lines        6732     6732              
  Branches      884      884              
==========================================
+ Hits         2396     2407      +11     
+ Misses       3876     3866      -10     
+ Partials      460      459       -1
Impacted Files Coverage Δ
addons/info/src/components/Story.js 88.88% <100%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870cee3...35af8b2. Read the comment docs.

@Hypnosphi Hypnosphi changed the base branch from master to next November 5, 2018 17:04
@MihaChicken
Copy link
Author

@danielduan thank you for reviewing my pull request.
Could you please tell me when it could be merged?

@shilman shilman added bug addon: info patch:yes Bugfix & documentation PR that need to be picked to main branch labels Nov 25, 2018
@shilman shilman merged commit c16e804 into storybookjs:next Nov 25, 2018
shilman added a commit that referenced this pull request Nov 25, 2018
…iption

GH-4643 fix docgen description displaying for info addon
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 25, 2018
@shilman
Copy link
Member

shilman commented Nov 25, 2018

Sorry I broke the build. I've committed updated snapshots to fix it but it looks like the circle's docker server is down ... hope this will get sorted out soon. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: info bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants