Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error on broken pipe during a partial write to stdout #208

Open
str4d opened this issue Feb 16, 2021 · 0 comments
Open

Don't error on broken pipe during a partial write to stdout #208

str4d opened this issue Feb 16, 2021 · 0 comments

Comments

@str4d
Copy link
Owner

str4d commented Feb 16, 2021

In #91 a user pointed out that a broken pipe during a partial write to stdout can occur as a normal matter of course (either due to ending a pseudo-seeking consumer like less early, or only needing a prefix of the decrypted file). We should not make this a hard error, and instead log a warning (if logging is enabled).

A broken pipe after no reading should IMO still be an error; if a user is explicitly trying to decrypt a file, but no downstream tool makes any attempt to use it, that seems like a bug in either the downstream tools or the user's command construction, and silently doing nothing would be terrible UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant