You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While going through the Rust 1.46 release steps, there was a clippy lint for same_item_push that falsely triggered in devicemapper-rs
"rustup default beta" (rustc 1.47.0-beta.1)
error: it looks like the same item is being pushed into this Vec
--> src/core/dm.rs:582:17
|
582 | targets.push((targ.sector_start, targ.length, target_type, params));
| ^^^^^^^
|
= note: `-D clippy::same-item-push` implied by `-D warnings`
= help: try using vec![(targ.sector_start, targ.length, target_type, params);SIZE] or targets.resize(NEW_SIZE, (targ.sector_start, targ.length, target_type, params))
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push
The original issue was filed on August 13, 2020:
same_item_push lint can trigger when the pushed value is not constant: rust-lang/rust-clippy#5902
However, there's a couple new issues related to same_item_push:
While going through the Rust 1.46 release steps, there was a clippy lint for same_item_push that falsely triggered in devicemapper-rs
The original issue was filed on August 13, 2020:
same_item_push lint can trigger when the pushed value is not constant: rust-lang/rust-clippy#5902
However, there's a couple new issues related to same_item_push:
"same_item_push is incorrect in several cases": rust-lang/rust-clippy#5985
"same_item_push being suggested for values that are not Copy or Clone": rust-lang/rust-clippy#5979
The text was updated successfully, but these errors were encountered: