Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop releasing stratisd_proc_macros in Fedoras #694

Closed
mulkieran opened this issue Mar 11, 2024 · 7 comments
Closed

Stop releasing stratisd_proc_macros in Fedoras #694

mulkieran opened this issue Mar 11, 2024 · 7 comments
Assignees

Comments

@mulkieran
Copy link
Member

We should try to do this to simplify our release procedures

This will require bringing into alignment our release tools and upstream. It will be necessary to make sure that our vendor tarfile agrees with our Cargo.toml file.

@mulkieran
Copy link
Member Author

mulkieran commented Mar 11, 2024

This probably depends on rust-lang/cargo#10134 because at present, if we do not vendor from the packaged release, then we do not vendor "stratisd_proc_macros" or any of its dependencies. This attempt may also have found a bug in the cargo_generate_buildrequires macro as it does not seem to have found the alternate version of the syn dependency that stratisd_proc_macros requires. All of these problems have to be resolved before we can proceed. BZ filed: https://bugzilla.redhat.com/show_bug.cgi?id=2269062

@mulkieran
Copy link
Member Author

We found out from the bz that we can do this if we use workspaces in the stratisd Cargo.toml.

@mulkieran
Copy link
Member Author

Orphaned.

@mulkieran
Copy link
Member Author

mulkieran commented May 7, 2024

Correct orphan notices are being sent out by Fedora...

@mulkieran
Copy link
Member Author

Past the six week mark and no objections, not surprisingly. Eventually should receive a notice to dead package it.

@mulkieran
Copy link
Member Author

Eventually @jbaublitz should receive the dead package notice, it should happen soon.

@mulkieran
Copy link
Member Author

We never received a notice to dead.package it, but a user called MaxwellG did that about two weeks ago[1]. I think that is enough, so I'm going to close this.

[1] https://src.fedoraproject.org/rpms/rust-stratisd_proc_macros/c/ddfafb28cb4719f30e8f66c3b248d233e68e6f77?branch=rawhide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done (1)
Development

No branches or pull requests

2 participants