Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat devicemapper thin pool feature args more formally #696

Open
mulkieran opened this issue Mar 18, 2024 · 1 comment
Open

Treat devicemapper thin pool feature args more formally #696

mulkieran opened this issue Mar 18, 2024 · 1 comment
Assignees

Comments

@mulkieran
Copy link
Member

In stratisd we both read and set these args and we store a select few in the Stratis metadata.

They are really a distinct set of keys, but they are represented as Strings. We should have a more enum-based way to represent them, either in devicemapper or in stratisd, in order to avoid the generic set of problems that arise from using undifferentiated strings for keys.

@mulkieran mulkieran self-assigned this Mar 18, 2024
@mulkieran
Copy link
Member Author

mulkieran commented Apr 29, 2024

This has been looked into stratis-storage/stratisd#3583. The most useful bit from that was the enum crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant