Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BDA::read out of BDA implementation #1582

Closed
mulkieran opened this issue Jul 15, 2019 · 3 comments · Fixed by #1599
Closed

Move BDA::read out of BDA implementation #1582

mulkieran opened this issue Jul 15, 2019 · 3 comments · Fixed by #1599
Assignees
@GuillaumeGomez
Labels
sub-issue issue that has a parent

Comments

@mulkieran
Copy link
Member

mulkieran commented Jul 15, 2019 •
edited
Loading

It only reads the locations of the sigblocks and the only method that depends on it is StaticHeader::setup.

We should probably make it a member of the static_header module, rather than a member of the StaticHeader impl, also. We'll handle this part of the big move later if it seems indicated. Let's just move it into the StaticHeader impl, so that it can be with its friend, StaticHeader::write.
@mulkieran mulkieran mentioned this issue Jul 15, 2019
Closed
5 tasks
@mulkieran mulkieran added the sub-issue issue that has a parent label Jul 15, 2019
@mulkieran
Copy link
Member Author

@GuillaumeGomez Could you address this one next?

@GuillaumeGomez
Copy link
Contributor

Sure. Leave me a few days.

@mulkieran
Copy link
Member Author

Absolutely, whenever you're ready!

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
sub-issue issue that has a parent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move BDA::read into StaticHeader::read GuillaumeGomez/stratisd
2 participants
@mulkieran @GuillaumeGomez