You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that BDA::wipe is invoked from outside the metadata module, so the method itself should be left. A new method should be created inside the static_header module.
Here's the new proposal:
Hoist the device_identifiers method right out of the BDA implementation and into the module top-level. This can be done by defining it, as a public method, in metadata/mod.rs. A lot of callers which currently call BDA::device_identifiers will need to be updated accordingly. Internal tests which call device_identifiers should be updated to call StaticHeader::setup instead.
Simultaneously:
Add another method in metadata/mod.rs called disown_device. Have this method call the StaticHeader::wipe method directly.
Move BDA::wipe into the StaticHeader implementation.
Update calls to BDA::wipe so that they instead call disown_device wherever necessary (or StaticHeader::wipe if they are metadata internal testing code).
Note that, after this, all StaticHeader-specific methods should have been moved into the StaticHeader implementation. So in the next step it should be possible to move the entire implementation into a separate module, one of the main parts of the goal of #1573.
The text was updated successfully, but these errors were encountered:
I think thatBDA::wipe
is invoked from outside the metadata module, so the method itself should be left. A new method should be created inside thestatic_header
module.Here's the new proposal:
Hoist the
device_identifiers
method right out of the BDA implementation and into the module top-level. This can be done by defining it, as a public method, in metadata/mod.rs. A lot of callers which currently callBDA::device_identifiers
will need to be updated accordingly. Internal tests which calldevice_identifiers
should be updated to callStaticHeader::setup
instead.Simultaneously:
Add another method in metadata/mod.rs called
disown_device
. Have this method call theStaticHeader::wipe
method directly.Move
BDA::wipe
into theStaticHeader
implementation.Update calls to
BDA::wipe
so that they instead calldisown_device
wherever necessary (orStaticHeader::wipe
if they are metadata internal testing code).Note that, after this, all StaticHeader-specific methods should have been moved into the
StaticHeader
implementation. So in the next step it should be possible to move the entire implementation into a separate module, one of the main parts of the goal of #1573.The text was updated successfully, but these errors were encountered: