-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have device_identifiers() return a struct instead of a tuple #1794
Comments
Call it |
Best to not touch until #1809 gets in. |
@GuillaumeGomez, I think this would be a good one, but we'ld like to get #1809 merged first. |
Sounds good to me. Please ping me once #1809 is merged. |
@GuillaumeGomez Please feel free to begin at any time. |
Ok! |
The struct should have two fields for the two identifiers and I don't think it needs any impl.
It can be used in the definition of the StaticHeader struct and also used in the result type of functions that call device_identifiers().
This should reduce type complexity and eliminate confusion in a few places.
It should wait until I've gotten in the PR that eliminates the device.rs module that defines DevOwnership, though, because that'll get rid of some invocations of device_identifiers.
The text was updated successfully, but these errors were encountered: