Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Priority: Low] Add sending all coins #205

Open
nopara73 opened this issue Sep 1, 2017 · 3 comments
Open

[Priority: Low] Add sending all coins #205

nopara73 opened this issue Sep 1, 2017 · 3 comments
Labels
Milestone

Comments

@nopara73
Copy link
Contributor

nopara73 commented Sep 1, 2017

A user cannot send all its coins out of the wallet without leaving some small amount in, because of the fee calculation, it should be supported.

Illustration:

@bokobza
Copy link
Contributor

bokobza commented Sep 4, 2017

This is already implemented in the wallet back-end. There is a method called GetMaximumSpendableBalance in the WalletController.
I think @dev0tion will add it to the UI when he's done with the TumbleBit work.

@nopara73
Copy link
Contributor Author

nopara73 commented Sep 4, 2017

Is it exposed to the HTTP API? If yes, could you insert the call here?

Are you sure it'll work correctly?
He might gets the maximum spendable balance, then makes a build transaction and it throws an error: not enough fee?
It should've be rather build-transaction, parameter amount: all.

@bokobza bokobza added this to the v1.0.0 milestone Oct 16, 2017
@dev0tion
Copy link
Collaborator

Max balance function added to the frontend logic in #279
Have yet to figure out a way to display it in the current coin unit.
Should be resolved in the next sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants