Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config parameters not used for anything #818

Closed
plebhash opened this issue Mar 27, 2024 · 6 comments
Closed

config parameters not used for anything #818

plebhash opened this issue Mar 27, 2024 · 6 comments

Comments

@plebhash
Copy link
Collaborator

plebhash commented Mar 27, 2024

some example config files have a fields that are never really used for anything in the roles implementations

  • coinbase_reward_sat

the config files should be cleaned up from those values

@star-gazer111
Copy link
Contributor

So the task as I understand is simply about commenting or removing those parameters from the example config files right @plebhash ?

@plebhash
Copy link
Collaborator Author

plebhash commented Apr 6, 2024

yes, but removing is better... leaving them as comments is just as useless as they are now

and the list above is just examples, I didn't look in detail through all the roles

ideally one should make a deep inspection trying to find all instances of unused config parameters

it can be done with a grep command, for example

@star-gazer111
Copy link
Contributor

star-gazer111 commented Apr 7, 2024

inspected & fixed here #838

@star-gazer111
Copy link
Contributor

I suppose this can be closed now @plebhash

@plebhash
Copy link
Collaborator Author

plebhash commented Apr 8, 2024

closed via #838

@plebhash plebhash closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@star-gazer111 @plebhash and others