bin/backup_contacts.php dying

[lhl]

So this happens:

lhl@snowball2 flickr $ php /www/flickr/bin/backup_contacts.php 
<pre style="text-align: left;">array (
  'ok' =&gt; 0,
  'error' =&gt; 'The Flickr API did not return any contacts',
)</pre>

Will debug and see if I can pinpoint at least where it's dying...

[straup]

Note to self: At a minimum this code should check that the Flickr API hasn't failed before purging contacts.

[straup]

This is sort of half-fixed, now. Specifically I've added retry code:

f581c75

I'll leave this ticket open until I tweak the code to buffer all new contacts (read: retries) before purging anything that's already in the database.

[straup]

Fixed: c9824f5

[lhl]

Been dealing w/ work issues so haven't gotten a chance to take much of a look. Did a merge, here are the results:

backup contacts for lhl
page: 1/ tries: 1/10 ok: 1
page: 1/4 tries: 1/10 ok: 0
page: 1/4 tries: 2/10 ok: 0
page: 1/4 tries: 3/10 ok: 0
page: 1/4 tries: 4/10 ok: 0
page: 1/4 tries: 5/10 ok: 0
page: 1/4 tries: 6/10 ok: 0
page: 1/4 tries: 7/10 ok: 0
page: 1/4 tries: 8/10 ok: 0
page: 1/4 tries: 9/10 ok: 0
page: 1/4 tries: 10/10 ok: 0

array (
  'ok' => 0,
  'error' => 'Unable to fetch contacts: The Flickr API did not return any contacts',
)

[straup]

Grrrrnnnn.

The good news is that it appears as though the retry code is working. This makes it seems like there's still a bug though:

page: 1/ tries: 1/10 ok: 1
page: 1/4 tries: 1/10 ok: 0

That second line should say "page: 2/4"

The bad news is that the Flickr API continues to wig out. It's almost as though contacts are being stored in Vespa or something...

[mncaudill]

I'm 95% sure that getContacts is hitting the DBs. There was some flip-flop for a while there due to some shit I don't remember, but I think it should be hitting the DBs.

[straup]

Also, just to be clear: This is no longer purging all the contacts for a user before re-fetching them via the API.

If there is a "fatal" error re-fetching contacts it just means that the local database is not updated. All previous contacts are left untouched.

[mojodna]

I'm seeing this intermittently as well (as of c9824f5).