Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadableStream TypeScript Compiler Error #1047

Closed
samchungy opened this issue Aug 1, 2024 · 2 comments · Fixed by #1048
Closed

ReadableStream TypeScript Compiler Error #1047

samchungy opened this issue Aug 1, 2024 · 2 comments · Fixed by #1048
Labels

Comments

@samchungy
Copy link
Contributor

samchungy commented Aug 1, 2024

Hey there, we're running into the following TypeScript compiler error:

https://github.com/seek-oss/skuba/actions/runs/10189049455/job/28186365681?pr=1622#step:9:36

Error: tsc      │ node_modules/.pnpm/[email protected]/node_modules/memfs/lib/node/types/misc.d.ts(109,61): error TS2552: Cannot find name 'ReadableStream'. Did you mean 'IReadStream'?

This only exists with the dom lib option which is not true for backend only projects.

Would you be okay with the approach the aws sdk v3 took? https://github.com/aws/aws-sdk-js-v3/pull/3889/files

@G-Rath
Copy link
Collaborator

G-Rath commented Aug 1, 2024

yup absolutely! (I actually had to push aws-sdk for a while to include that fix 😅)

Copy link

github-actions bot commented Aug 1, 2024

🎉 This issue has been resolved in version 4.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants