Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unitless doesn't work with vcssom #232

Open
hnordt opened this issue Apr 17, 2019 · 1 comment
Open

unitless doesn't work with vcssom #232

hnordt opened this issue Apr 17, 2019 · 1 comment

Comments

@hnordt
Copy link

hnordt commented Apr 17, 2019

When using vcssom addon, the unitless addon has no effect.

@streamich
Copy link
Owner

streamich commented Apr 17, 2019

Yeah, currently cssom and vcssom addons are completely separate. But, I guess, it does make sense to integrate them with the rest of the addons.

This line should be changed to something like:

const declarations = renderer.decl(property, newDecl[property]).split(';');
for (var i = 0; i < declarations.length; i++) {
  var parts = declarations[i].split(':');
  style.setProperty(parts[0], parts[1]);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants