Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useSet): add toggle a method #968

Merged
merged 3 commits into from
Mar 3, 2020
Merged

feat(useSet): add toggle a method #968

merged 3 commits into from
Mar 3, 2020

Conversation

dispix
Copy link
Contributor

@dispix dispix commented Feb 13, 2020

Description

This adds a toggle method to the useSet hook. It creates a handy wrapper on top of add and remove.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

@wardoost wardoost self-requested a review February 15, 2020 10:02
wardoost
wardoost suggested changes Feb 15, 2020
View reviewed changes
stories/useSet.story.tsx Outdated Show resolved Hide resolved
src/useSet.ts Outdated Show resolved Hide resolved
@wardoost wardoost merged commit 477614f into streamich:master Mar 3, 2020
@wardoost
Copy link
Contributor

wardoost commented Mar 3, 2020

Thanks @dispix 🙌

streamich pushed a commit that referenced this pull request Mar 3, 2020
@semantic-release-bot
chore(release): 13.27.0 [skip ci]
9586598 
# [13.27.0](v13.26.5...v13.27.0) (2020-03-03)

### Features

* **useSet:** add toggle a method ([#968](#968)) ([477614f](477614f))
@streamich
Copy link
Owner

🎉 This PR is included in version 13.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardoost wardoost wardoost requested changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dispix @wardoost @streamich