Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

Topic properties support for update and remove #5911

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Topic properties support for update and remove #5911

merged 6 commits into from
Sep 27, 2023

Conversation

liangyepianzhou
Copy link

@liangyepianzhou liangyepianzhou commented Sep 27, 2023 •
edited
Loading

Motivation

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

AnonHxy and others added 6 commits September 27, 2023 13:51
@AnonHxy @liangyepianzhou
[broker][admin]Add api for update topic properties (apache#17238)
ff2c1ac 
(cherry picked from commit b21f728)
@yuruguo @liangyepianzhou
[broker][admin] Add cmd to remove topic properties (apache#17337)
351470c 
* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
(cherry picked from commit 6f8dbc7)
@Flowermin @liangyepianzhou
[fix][broker] Fix NPE when updating topic's properties (apache#17352)
28ecbde 
Co-authored-by: bjhuxiaohua <[email protected]>
(cherry picked from commit f1d1158)
(cherry picked from commit 723ad75)
@liangyepianzhou
[fix][broker] Fix NPE when update topic properties.
337fdab 
### Motivation

In Pulsar 2.10, when creating a producer/consumer that auto-creates a topic and then attempts to update its properties, a NullPointerException (NPE) occurs. The reason is that Pulsar 2.10 does not correctly handle the case when the properties are `null`.
### Modifications

Add an NPE check.

(cherry picked from commit 0b02321)
@liangyepianzhou
remove release profile
6bec650
@liangyepianzhou
import
e15238d
@liangyepianzhou
Copy link
Author

https://github.com/liangyepianzhou/pulsar/pull/41

@liangyepianzhou liangyepianzhou changed the title Cherry pick for lego Cherry pick Sep 27, 2023
@codelipenghui codelipenghui merged commit 6d7dfcf into streamnative:branch-2.10.5.2-5ce22c Sep 27, 2023
2 checks passed
This was referenced Sep 27, 2023
Merged
Merged
@liangyepianzhou liangyepianzhou changed the title Cherry pick Topic properties support for update and remove Sep 27, 2023
@liangyepianzhou liangyepianzhou mentioned this pull request Sep 27, 2023
Merged
15 tasks
gaoran10 pushed a commit that referenced this pull request Oct 9, 2023
@liangyepianzhou @gaoran10
Topic properties support for update and remove (#5911)
6564e6e 
(cherry picked from commit 6d7dfcf)
liangyepianzhou added a commit that referenced this pull request Oct 25, 2023
@liangyepianzhou
Topic properties support for update and remove (#5939)
b67024d 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
liangyepianzhou added a commit that referenced this pull request Oct 25, 2023
@liangyepianzhou
Topic properties support for update and remove (#5941)
17b26e7 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
liangyepianzhou added a commit that referenced this pull request Oct 25, 2023
@liangyepianzhou
Topic properties support for update and remove (#5943)
3523c72 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
liangyepianzhou added a commit that referenced this pull request Dec 13, 2023
@liangyepianzhou
Topic properties support for update and remove (#5979)
a0d4c7d 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
liangyepianzhou added a commit that referenced this pull request Dec 14, 2023
@liangyepianzhou
Topic properties support for update and remove (#5911)
fd211c2 
(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)
liangyepianzhou added a commit that referenced this pull request Dec 14, 2023
@liangyepianzhou
Topic properties support for update and remove (#5981)
6bed83b 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
poorbarcode pushed a commit that referenced this pull request Feb 3, 2024
@liangyepianzhou @poorbarcode
Topic properties support for update and remove (#5981)
b31cf2e 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
(cherry picked from commit 6bed83b)
liangyepianzhou added a commit that referenced this pull request Mar 12, 2024
@liangyepianzhou
Topic properties support for update and remove (#5981)
d00b88a 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
(cherry picked from commit 6bed83b)
liangyepianzhou added a commit that referenced this pull request Mar 12, 2024
@liangyepianzhou
Topic properties support for update and remove (#5981) (#6058)
2b83e05 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
(cherry picked from commit 6bed83b)
liangyepianzhou added a commit that referenced this pull request Mar 13, 2024
@liangyepianzhou
Topic properties support for update and remove (#5981)
3a7b2f8 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
(cherry picked from commit 6bed83b)
liangyepianzhou added a commit that referenced this pull request Mar 13, 2024
@liangyepianzhou
Topic properties support for update and remove (#5981) (#6062)
ec025cc 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
(cherry picked from commit 6bed83b)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liangyepianzhou @codelipenghui @AnonHxy @yuruguo @Flowermin