Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add failFast config option to exit as soon as an issue encountered #2307

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

Maxim-Mazurok
Copy link
Contributor

@Maxim-Mazurok Maxim-Mazurok commented Jan 24, 2022

Closes #2294

This is my first contribution, not sure if I placed this config option in the right place, and also not sure if that's the most optimal way to test this, but I guess it works. Any feedback is appreciated.

@Jason3S
Copy link
Collaborator

Jason3S commented Jan 24, 2022

@Maxim-Mazurok,

Thank you. Looks good so far. I'll add a few comments.

@Jason3S Jason3S changed the title Add --fail-fast to exit as soon as an issue encountered feat: Add --fail-fast to exit as soon as an issue encountered Jan 24, 2022
@Maxim-Mazurok
Copy link
Contributor Author

I just noticed that adding failFast to the config doesn't add --fail-fast to CLI automatically, which probably would be nice to have, would you like me to add it?

@Jason3S
Copy link
Collaborator

Jason3S commented Jan 24, 2022

This is great!

I just noticed that adding failFast to the config doesn't add --fail-fast to CLI automatically, which probably would be nice to have, would you like me to add it?

Yes, please add it to cspell/commandLint.ts

@Jason3S Jason3S marked this pull request as ready for review January 25, 2022 07:00
@Jason3S
Copy link
Collaborator

Jason3S commented Jan 25, 2022

This is great!

I just noticed that adding failFast to the config doesn't add --fail-fast to CLI automatically, which probably would be nice to have, would you like me to add it?

Yes, please add it to cspell/commandLint.ts

You only need to add one line. I can do it if you prefer.

@Jason3S Jason3S changed the title feat: Add --fail-fast to exit as soon as an issue encountered feat: Add failFast config option to exit as soon as an issue encountered Jan 26, 2022
@Jason3S Jason3S merged commit 26dd25a into streetsidesoftware:main Jan 26, 2022
@Jason3S
Copy link
Collaborator

Jason3S commented Jan 26, 2022

@Maxim-Mazurok,

I'll land this now and add the line afterwards. I want your change to make it in for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repl mode for stdin, or fail fast
2 participants