feat: improve spell checking speed and allow multiple exclude arguments #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Jason3S
commented
Dec 26, 2020
Jason3S
commented
- Improve speed of spell checking by filtering when scanning for files.
- Explicitly allow multiple excludes on the command line.
Duplicate file checks were removed.
nschonni
reviewed
Dec 26, 2020
integration-tests/config/config.json
Outdated
| @@ -115,8 +119,7 @@ | |||
| "args": [ | |||
| "examples/**/*.html", | |||
| "aria-practices.html", | |||
| "**/*.md", | |||
| "*.md" | |||
| "**/*.md" | |||
There was a problem hiding this comment.
This one actually does everything with "**/*.*", and used the ignoreFilePaths to exclude
There was a problem hiding this comment.
Great, I'll fix it.
nschonni
reviewed
Dec 26, 2020
integration-tests/config/config.json
Outdated
| "aria-practices.html", | ||
| "**/*.md", | ||
| "*.md" | ||
| "**/*" |
There was a problem hiding this comment.
It was picking up "zero files" with this glob
Suggested change
| "**/*" | |
| "**/*.*" |
There was a problem hiding this comment.
With **/* it seems to be picking up 336 files: test (14.x, ubuntu-latest, w3c/aria-practices w3c/specberus)
There was a problem hiding this comment.
Sorry, I did missread the snapshot, but the other pattern is what's used upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.