Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contextual menu icons could be bigger #2429

Open
DomeAlessi opened this issue Sep 5, 2024 · 5 comments
Open

Contextual menu icons could be bigger #2429

DomeAlessi opened this issue Sep 5, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@DomeAlessi
Copy link

Hello!

I wanted to ask if it's possible to scale up a bit the size of the icons in the context menus.
Right now they are very little and the image is very difficult to perceive even on a close monitor due the big contrast with the background.
Please refer to the attached screenshot below.

Describe the solution you'd like
To enhance readability, I suggest making the icons slightly larger and adjusting the contrast between the icons and the dark menu background. This change would also improve the visibility of disabled items, making the overall interface easier to navigate.

Thank you!
image

@DomeAlessi DomeAlessi added the enhancement New feature or request label Sep 5, 2024
@VaclavElias
Copy link
Contributor

This is something weird! Not sure when this happened, the icons should be like this. The image is from one of the old tutorials
image

And not like this
image

I wonder if we made some change or Windows 11 is doing something for us 🤣

@DomeAlessi
Copy link
Author

Well at least I am glad it's not the intended size and something is wrong somewhere :D anyway yeah I am on windows 11 and I am at 100% DPI settings on all monitors.

@Basewq
Copy link
Contributor

Basewq commented Sep 7, 2024

I don't have time to have a closer look at this, but the first that comes to mind is #1807, there's a bunch of width/height value changes that may be the cause of this issue.

@DomeAlessi
Copy link
Author

Yeah if you remove the Margin="5,5" from MenuItem ControlTemplate ContentPresenter in Stride.Core.Presentation.Wpf\Themes\ThemeSelector.xaml the icons can stretch to the max of their parent:

image

image

@DomeAlessi
Copy link
Author

En passant I see that the spacing system is kinda mixed, i see lot of multiple-of-5 margins which are not great for application scaling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants