Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update telemetry logic to use new VSCode APIs #200

Open
gracegoo-stripe opened this issue Mar 31, 2021 · 0 comments
Open

Update telemetry logic to use new VSCode APIs #200

gracegoo-stripe opened this issue Mar 31, 2021 · 0 comments

Comments

@gracegoo-stripe
Copy link
Contributor

VSCode has added APIs that do a better check of the user's telemetry settings: https://code.visualstudio.com/updates/v1_55#_telemetry-enablement-api

Currently we check two workspace settings: telemetry.enableTelemetry and stripe.telemetry.enabled. The former should be replaced by VSCode's isTelemetryEnabled API which also takes into account a CLI flag the user can set. They also added an event that fires when that changes that we should incorporate as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gracegoo-stripe @etsai-stripe