Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake imported targets #975

Closed
farindk opened this issue Oct 9, 2023 · 3 comments · Fixed by #976
Closed

Use CMake imported targets #975

farindk opened this issue Oct 9, 2023 · 3 comments · Fixed by #976

Comments

@farindk
Copy link
Contributor

farindk commented Oct 9, 2023

Moving @kmilos comment from #973 into a issue of its own.

maybe it's time to bump CMake minimum required version and simplifyby using imported targets ZLIB::ZLIB and PNG::PNG...

Do you know what minimum cmake version is required for that? I think the current upper limit might be cmake v3.16.3 (Ubuntu 20.04).

3.1 for ZLIB, 3.5 for PNG

@kmilos
Copy link
Contributor

kmilos commented Oct 9, 2023

And JPEG::JPEG is available since 3.12

@farindk
Copy link
Contributor Author

farindk commented Oct 9, 2023

This was also proposed in PR #754.
@fancycode Which minimum CMake version is required for packaging? Can we switch to v3.12 ?

@fancycode
Copy link
Member

Ubuntu Focal (20.04) ships cmake 3.16.3, so 3.12 should be ok. We can probably drop support for older versions of Ubuntu for new releases anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants