go: Call 'heif_context_read_from_memory_without_copy' instead of deprecated function #67
Conversation
|
Please make sure that this does not introduce hard to find conflicts with the garbage collector. |
…ecated function
heif.c:319 says:
// DEPRECATED: use heif_context_read_from_memory_without_copy() instead.
leonklingele-work
force-pushed
the
go-read-memory-nocopy
branch
from
de0d6b3
to
ff75b2d
Compare
|
@farindk ptal. This now allocates C memory and frees it again before exiting. |
|
Doesn't that just set the finalizer for the copied array? I.e. it can still garbage-collect the array before the heif_context? I think the finalizer should be attached to the context, such that the array lifetime is at least as long as the context. Then again, I have no idea about Go... So I might be wrong. |
| @@ -321,7 +321,12 @@ func (c *Context) ReadFromFile(filename string) error { | |||
|
|
|||
| func (c *Context) ReadFromMemory(data []byte) error { | |||
| // TODO: Use reader API internally. | |||
| err := C.heif_context_read_from_memory(c.context, unsafe.Pointer(&data[0]), C.size_t(len(data)), nil) | |||
| cData := C.CBytes(data) | |||
There was a problem hiding this comment.
Why not store a reference to data in the Context? This would make sure it is kept alive until the Context is released.
If you do that, make sure to clear the referene manually if it is no longer needed (e.g. when loading from a file in the same context).
heif.c:319 says:
// DEPRECATED: use heif_context_read_from_memory_without_copy() instead.