Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karma-runner: stop using raw cli options #2847

Closed
nicojs opened this issue Apr 21, 2021 · 0 comments · Fixed by #3020
Closed

karma-runner: stop using raw cli options #2847

nicojs opened this issue Apr 21, 2021 · 0 comments · Fixed by #3020
Labels
🚀 Feature request New feature request 👶 Good first issue Good for newcomers

Comments

@nicojs
Copy link
Member

nicojs commented Apr 21, 2021

The current way of running Karma is deprecated. When running the integration tests you can see it:

 21 04 2021 17:32:20.977:WARN [runner]: Passing raw CLI options to `runner(config, done)` is deprecated. Use `parseConfig(configFilePath, cliOptions, {promiseConfig: true, throwErrors: true})` to prepare a processed `Config` instance and pass that as the `config` argument instead.

Let's do exactly what they specify in this warning to fix this.

Note: We might need to still send raw options for older versions of Karma. We'll have to see. We can start with the new implementation, since we have an e2e test for the oldest supported karma version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Feature request New feature request 👶 Good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant